Skip to content

Update for NIC v2.3.0 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

Update for NIC v2.3.0 #26

merged 1 commit into from
Jul 13, 2022

Conversation

@ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Jul 12, 2022

Proposed changes

Update for NIC v2.3.0. Changes based on Helm chart v0.14.0.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested review from a team, haywoodsh, lucacome and shaun-nx July 12, 2022 15:16
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 12, 2022
@ciarams87 ciarams87 mentioned this pull request Jul 12, 2022
Merged
6 tasks
@ciarams87 ciarams87 merged commit 7463c69 into main Jul 13, 2022
@ciarams87 ciarams87 deleted the nic-2.3.0-updates branch July 13, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

2 more reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ciarams87 @lucacome @jjngx